linux-kernel - Re: [PATCH v2] Add Dallas DS1390 RTC chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081020114607.1b0299cb@i1501.lan.towertech.it>
Date:	Mon, 20 Oct 2008 11:46:07 +0200
From:	Alessandro Zummo <alessandro.zummo@...ertech.it>
To:	Mark Jackson <mpfj@...c.co.uk>
Cc:	dbrownell@...rs.sourceforge.net,
	lkml <linux-kernel@...r.kernel.org>, rtc-linux@...glegroups.com,
	spi-devel-general@...ts.sourceforge.net
Subject: Re: [PATCH v2] Add Dallas DS1390 RTC chip

On Mon, 20 Oct 2008 09:41:18 +0100
Mark Jackson <mpfj@...c.co.uk> wrote:

> +struct ds1390 {
> +	struct rtc_device *rtc;
> +	u8 buf[9];	/* cmd + 8 registers */
> +	u8 tx_buf[2];
> +	u8 rx_buf[2];
> +};
> +

 don't we still have too many buffers?

 the use of bin2bcd an bcd2bin (lowercase) would also be appreciated.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/