linux-kernel - Re: [PATCH] x86, ioremap: use %pR in printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1224501768.7654.144.camel@pasglop>
Date:	Mon, 20 Oct 2008 22:22:48 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Linus Torvalds <torvalds@...l.org>, linux-kernel@...r.kernel.org,
	David Miller <davem@...emloft.net>, linux-pci@...r.kernel.org,
	yhlu.kernel@...il.com, Andrew Morton <akpm@...ux-foundation.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH] x86, ioremap: use %pR in printk

On Mon, 2008-10-20 at 22:15 +1100, Benjamin Herrenschmidt wrote:
> > so how about something like the two patches below (ontop of Linus's 
> > patch): the first patch introduces a "small" resource pointer printout 
> > format: %pr - the little brother of %pR.
> > 
> > The output format is [0x00001234] - minimum width is 8.
> > 
> > The second patch takes advantage of it in ioremap.c.
> 
> Well, I did the exact same patch except I used the same function
> and just added a flag for "R" vs. "r". However, I didn't post it
> because I wasn't too happy with passing by pointer and I wasn't
> sure whether we wanted to keep the letter after p uppercase or not... In
> any case, I kept it as a thing to discuss after the first one goes in.
> 
> At this stage, I'm tempted to go for a %pP for printing a pointer to
> a phys_addr_t (and that's the same as resource_size_t, just more generic
> nowadays, since those were consolidated).
> 
> Still not too happy with the pointer thing but that's the best we can
> do I suppose without losing gcc type checking.

Oh, and I didn't like having the brackets around something that isn't
a range too but that's a minor details.

Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/