linux-kernel - Re: [patch 2/2] introduce vdso on s390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081020130650.GA4465@osiris.boeblingen.de.ibm.com>
Date:	Mon, 20 Oct 2008 15:06:50 +0200
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Bastian Blank <bastian@...di.eu.org>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
	linux-arch@...r.kernel.org
Subject: Re: [patch 2/2] introduce vdso on s390

On Fri, Oct 17, 2008 at 05:34:36PM +0200, Bastian Blank wrote:
> On Wed, Oct 15, 2008 at 07:45:08PM +0200, Martin Schwidefsky wrote:
> > +void update_vsyscall(struct timespec *wall_time, struct clocksource *clock)
> > +{
> > +	if (clock != &clocksource_tod)
> > +		return;
> > +
> > +	/* Make userspace gettimeofday spin until we're done. */
> > +	++vdso_data->tb_update_count;
> > +	smp_mb();
> > +	vdso_data->xtime_tod_stamp = clock->cycle_last;
> > +	vdso_data->xtime_clock_sec = xtime.tv_sec;
> > +	vdso_data->xtime_clock_nsec = xtime.tv_nsec;
> > +	vdso_data->wtom_clock_sec = wall_to_monotonic.tv_sec;
> > +	vdso_data->wtom_clock_nsec = wall_to_monotonic.tv_nsec;
> > +	smp_wmb();
> 
> Different barriers?

Doesn't matter. They are all the same anyway on s390. But I changed it to
smp_wmb instead.

> > +	++(vdso_data->tb_update_count);
>
> Why ++(...)?

Removed the braces.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/