linux-kernel - Re: [PATCH] x86: amd_iommu: fix nasty bug that caused ILLEGAL_DEVICE_TABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081020160603.GA5744@elte.hu>
Date:	Mon, 20 Oct 2008 18:06:03 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Joerg Roedel <joro@...tes.org>
Cc:	Andreas Herrmann <andreas.herrmann3@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	stable@...nel.org
Subject: Re: [PATCH] x86: amd_iommu: fix nasty bug that caused
	ILLEGAL_DEVICE_TABLE_ENTRY errors


* Joerg Roedel <joro@...tes.org> wrote:

> Argh. Very stupid bug. This explains why it worked on my system with 1G
> RAM and failed on some others with more. Thanks for the fix. I also CC
> stable@...nel.org.
> 
> On Thu, Oct 16, 2008 at 04:27:36PM +0200, Andreas Herrmann wrote:
> > We are on 64-bit so better use u64 instead of u32 to deal with
> > addresses:
> > 
> > static void __init iommu_set_device_table(struct amd_iommu *iommu)
> > {
> >         u64 entry;
> >   ...
> >         entry = virt_to_phys(amd_iommu_dev_table);
> >   ...
> > 
> > (I am wondering why gcc 4.2.x did not warn about the assignment
> > between u32 and unsigned long.)
> > 
> > Cc: iommu@...ts.linux-foundation.org
> > Cc: Joerg Roedel <joerg.roedel@....com>
> > Signed-off-by: Andreas Herrmann <andreas.herrmann3@....com>
> 
> Signed-off-by: Joerg Roedel <joerg.roedel@....com>

applied to tip/x86/urgent, thanks guys!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/