Message-ID: <787b0d920810201107p7ea3c1een2b7809d5cbfbc6bc@mail.gmail.com>
Date:	Mon, 20 Oct 2008 14:07:28 -0400
From:	"Albert Cahalan" <acahalan@...il.com>
To:	"Mel Gorman" <mel@....ul.ie>
Cc:	adobriyan@...il.com, kosaki.motohiro@...fujitsu.com,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] Report the size of pages backing VMAs in /proc V3

On Mon, Oct 20, 2008 at 6:06 AM, Mel Gorman <mel@....ul.ie> wrote:
> On (20/10/08 05:18), Albert Cahalan didst pronounce:

>> Looping on stat() while chopping off suspected tags is dreadful.
>> Besides just being gross, it's slow.
>
> You're probably right. It's a bit weird that it's what you have to do to
> figure out if the file in /proc/PID/maps is really there or not.

Actually you can't do this, because of directory permissions.

>> Obviously, every author of a /proc-based tool has been forced to
>> take a random guess at the ABI. The /proc/*/smaps is so gross and
>> that I put off writing a parser for years.
>
> I intend to take a stab at it for the purposes of teaching pmap to print
> the pagesizes if the smaps change gets picked up.

FYI, "KernelPageSize" is at least unique under the perfect
hash function I'm using to parse the damn smaps file.

hash = ( ( (s[8]&15) + (s[1]&15) ) ^ (s[0]&3) ) & 31;

I have to wonder if we'll be getting mixed page sizes
within a single mapping, making such info unusable.

>> Right before the filename, you can add anything except a '/'.
>> You could add a few columns of numbers or a second flags field.
>
> My fear was about parsers that hard-coded what number field stored the
> filename. If a column was added for pagesize for example, then parsers
> would think the pagesize was the filename.

It's possible. Every parser I've examined does strchr()
or similar to find that '/' character.

Maybe try some dummy patches in a linux-next kernel?
Give each one a month. You could do "xyz" concatenated
to the flags, a second "rwx" concatenated to the flags,
a single column of "0" before the filename, and several
columns of "parsertest" before the filename.

> Now, that is an interested idea, albeit it's not one that is easily
> human-readable and would need a second parser like pmap but that's ok. If
> parsing smaps turns into a total pain in the ass

I assure you that parsing smaps is a total pain in the ass,
especially if you want tolerable performance. Something
like "top" is not viable if it performs like a Python script.

>> BTW, I'm thinking that the /proc/*/*maps files fail when the
>> lines exceed 4096 bytes. The pathname may legitimately be that
>> long, plus it can be backslash escaped, plus there is all the
>> junk on the beginning.
>
> Yes. While it's unlikely to be exceeded, a file could be 4096 bytes long
> and the other fields will then cause a problem. It was because of things
> like this, I was ok with dropping the idea of adding (attribute[=value])
> from the end of the filename.

"unlikely" is not something one should trust. I think you
can even get a name longer than 4096 bytes if you make
directories relative to the current directory and keep
changing directories as you make the directories.
Then double that with backslashes becoming \\ or
newlines becoming \n (must be escaped) in the output.

I think /proc/*/maps has been broken ever since it was
converted to seq_file, and maybe ever since it got filenames.
Prior to the filenames, lines were fixed-width records.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists