lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1224538518.7654.164.camel@pasglop>
Date:	Tue, 21 Oct 2008 08:35:18 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Ingo Molnar <mingo@...e.hu>, Linus Torvalds <torvalds@...l.org>,
	linux-kernel@...r.kernel.org, David Miller <davem@...emloft.net>,
	linux-pci@...r.kernel.org, yhlu.kernel@...il.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH] x86, ioremap: use %pR in printk

On Mon, 2008-10-20 at 14:58 +0200, Johannes Berg wrote:
> On Mon, 2008-10-20 at 13:36 +0200, Ingo Molnar wrote:
> 
> > +	/* room for the actual number, the "0x" and the final zero */
> > +	char sym[2*sizeof(phys_addr_t) + 2];
> 
> Buffer overflow.

It's actually not going to overflow as we pass the end of the buffer to
"number" but we'll miss a digit.

Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ