linux-kernel - Re: [PATCH] atmel_lcdfb: unsigned irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <48FD96C9.6060204@atmel.com>
Date:	Tue, 21 Oct 2008 10:46:01 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	roel kluin <roel.kluin@...il.com>
CC:	linux-fbdev-devel@...ts.sourceforge.net,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] atmel_lcdfb: unsigned irq_base cannot be negative

Hi,

roel kluin :
> unsigned irq_base cannot be negative

Indeed. Thanks for taking this point !

> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
> index f8d0a57..f93f57a 100644
> --- a/drivers/video/atmel_lcdfb.c
> +++ b/drivers/video/atmel_lcdfb.c
> @@ -857,12 +857,12 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
>  		goto stop_clk;
>  	}
>  
> -	sinfo->irq_base = platform_get_irq(pdev, 0);
> -	if (sinfo->irq_base < 0) {
> +	ret = platform_get_irq(pdev, 0);
> +	if (ret < 0) {
>  		dev_err(dev, "unable to get irq\n");
> -		ret = sinfo->irq_base;
>  		goto stop_clk;
>  	}
> +	sinfo->irq_base = ret;

I prefer changing the definition of irq_base to plain int.

So the patch becomes obvious:
-       unsigned long           irq_base;
+       int                     irq_base;

What do you think of this ?

I repost a patch addressing this issue.

Regards,
-- 
Nicolas Ferre

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/