linux-kernel - Re: [PATCH] pci: use pci_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Oct 2008 11:17:51 +0200
From:	"Hans J. Koch" <hjk@...utronix.de>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	hjk@...utronix.de, tglx@...x.de, Greg KH <gregkh@...e.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pci: use pci_ioremap_bar() in drivers/uio

Added Greg KH to CC since he handles the UIO patch queue. Also added
lkml since UIO patches are discussed there.

On Mon, Oct 20, 2008 at 09:54:44PM -0700, Arjan van de Ven wrote:
> 
> >From 8d0e600e37f36d379b2f7652912f1b1090c9dfa3 Mon Sep 17 00:00:00 2001
> From: Arjan van de Ven <arjan@...ux.intel.com>
> Date: Sun, 28 Sep 2008 16:20:35 -0700
> Subject: [PATCH] pci: use pci_ioremap_bar() in drivers/uio
> 
> Use the newly introduced pci_ioremap_bar() function in drivers/uio.
> pci_ioremap_bar() just takes a pci device and a bar number, with the goal
> of making it really hard to get wrong, while also having a central place
> to stick sanity checks.
> 
> CC: tglx@...x.de
> Signed-off-by: Arjan van de Ven <arjan@...ux.intel.com>

Signed-off-by: Hans J. Koch <hjk@...utronix.de>

> ---
>  drivers/uio/uio_cif.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/uio/uio_cif.c b/drivers/uio/uio_cif.c
> index 5737606..c60b8fc 100644
> --- a/drivers/uio/uio_cif.c
> +++ b/drivers/uio/uio_cif.c
> @@ -57,8 +57,7 @@ static int __devinit hilscher_pci_probe(struct pci_dev *dev,
>  	info->mem[0].addr = pci_resource_start(dev, 0);
>  	if (!info->mem[0].addr)
>  		goto out_release;
> -	info->mem[0].internal_addr = ioremap(pci_resource_start(dev, 0),
> -					     pci_resource_len(dev, 0));
> +	info->mem[0].internal_addr = pci_ioremap_bar(dev, 0);
>  	if (!info->mem[0].internal_addr)
>  		goto out_release;
>  
> -- 
> 1.5.5.1
> 
> 
> -- 
> Arjan van de Ven 	Intel Open Source Technology Centre
> For development, discussion and tips for power savings, 
> visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/