linux-kernel - Re: [PATCH] Fix kexec compile error, undeclared 'vmlist'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081021105404.GD22217@kernel.dk>
Date:	Tue, 21 Oct 2008 12:54:05 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	linux-kernel@...r.kernel.org
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	oomichi@....nes.nec.co.jp
Subject: Re: [PATCH] Fix kexec compile error, undeclared 'vmlist'

On Tue, Oct 21 2008, Jens Axboe wrote:
> Hi,
> 
> Current -git fails to compile, at least on ppc:
> 
> kernel/kexec.c: In function 'crash_save_vmcoreinfo_init':
> kernel/kexec.c:1374: error: 'vmlist' undeclared (first use in this function)
> kernel/kexec.c:1374: error: (Each undeclared identifier is reported only once
> kernel/kexec.c:1374: error: for each function it appears in.)
> kernel/kexec.c:1410: error: invalid use of undefined type 'struct vm_struct'
> 
> It's missing a vmalloc.h include, introduced by
> acd99dbf54020f5c80b9aa2f2ea86f43cb285b02.
> 
> Signed-off-by: Jens Axboe <jens.axboe@...cle.com>
> 
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 777ac45..ac0fde7 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -30,6 +30,7 @@
>  #include <linux/pm.h>
>  #include <linux/cpu.h>
>  #include <linux/console.h>
> +#include <linux/vmalloc.h>
>  
>  #include <asm/page.h>
>  #include <asm/uaccess.h>

So this was already fixed and pushed out by Tony, so nevermind the extra
noise. Apparently I had pulled this morning just before, so missed the
last few changes.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/