linux-kernel - Re: [PATCH 01/35] x86: clean up speedctep-centrino and reduce cpumask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48FDCAFB.3070802@sgi.com>
Date:	Tue, 21 Oct 2008 05:28:43 -0700
From:	Mike Travis <travis@....com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
CC:	Ingo Molnar <mingo@...e.hu>, Rusty Russell <rusty@...tcorp.com.au>,
	davej@...emonkey.org.uk, Jeremy Fitzhardinge <jeremy@...p.org>,
	Jes Sorensen <jes@....com>, IA64 <linux-ia64@...r.kernel.org>,
	S390 <linux-s390@...r.kernel.org>, peterz@...radead.org,
	Jack Steiner <steiner@....com>, linux-kernel@...r.kernel.org,
	Eric Dumazet <dada1@...mosbay.com>,
	PowerPC <linuxppc-dev@...abs.org>,
	Andi Kleen <andi@...stfloor.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Yinghai Lu <yhlu.kernel@...il.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	SPARC <sparclinux@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH 01/35] x86: clean up speedctep-centrino and reduce cpumask_t
 usage

Stephen Rothwell wrote:
> Hi Mike,
> 
> Just a first small thing:
> 
> On Mon, 20 Oct 2008 10:03:20 -0700 Mike Travis <travis@....com> wrote:
>> 1) The #ifdef CONFIG_HOTPLUG_CPU seems unnecessary these days.
>> 2) The loop can simply skip over offline cpus, rather than creating a tmp mask.
>> 3) set_mask is set to either a single cpu or all online cpus in a policy.
>>    Since it's just used for set_cpus_allowed(), any offline cpus in a policy
>>    don't matter, so we can just use cpumask_of_cpu() or the policy->cpus.
>>
>> From: Rusty Russell <rusty@...tcorp.com.au>
>> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
>> Signed-off-by: Mike Travis <travis@....com>
> 
> The From: line should be the first nonempty line in the mail to get the
> attribution correct.
> 

Ahh, ok, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/