linux-kernel - Re: [PATCH 1/4] CAPABILITIES: add cpu endian vfs caps structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Oct 2008 09:22:17 -0400
From:	Eric Paris <eparis@...hat.com>
To:	"Andrew G. Morgan" <morgan@...nel.org>
Cc:	linux-kernel@...r.kernel.org, linux-audit@...hat.com,
	viro@...iv.linux.org.ok, sgrubb@...hat.com, serue@...ibm.com
Subject: Re: [PATCH 1/4] CAPABILITIES: add cpu endian vfs caps structure

On Mon, 2008-10-20 at 22:50 -0700, Andrew G. Morgan wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Eric Paris wrote:
> > This patch add a generic cpu endian caps structure and enternally available
> > functions which retrieve fcaps information from disk.  This information is
> > necessary so fcaps information can be collected and recorded by the audit
> > system.
> > 
> [...]
> >  	CAP_FOR_EACH_U32(i) {
> > -		__u32 value_cpu;
> > -
> > -		if (i >= tocopy) {
> > -			/*
> > -			 * Legacy capability sets have no upper bits
> > -			 */
> > -			bprm->cap_post_exec_permitted.cap[i] = 0;
> > +		if (i > tocopy) {
> 
> Shouldn't the above still be (i >= tocopy) ?

just replaced this with

if (i >= tocopy)
        break;

I'm already zero'ing out the cap data at the beginning so there isn't
really a need for me to zero the upper bits if they aren't set.

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/