linux-kernel - Re: [PATCH] include io.h in pci.h to avoid pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200810211028.38630.jbarnes@virtuousgeek.org>
Date:	Tue, 21 Oct 2008 10:28:38 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] include io.h in pci.h to avoid pci_ioremap build errors

On Tuesday, October 21, 2008 10:07 am Jesse Barnes wrote:
> Ingo pointed out that the m32r build was broken by pci_ioremap.  It looks
> like some files include pci.h w/o including io.h.  The latter defines
> ioremap_* if present, so it makes sense to include it in pci.h now that we
> have pci_ioremap there.
>
> I'll queue this up in my tree for the next pull request, but affected users
> can apply this patch in the meantime.
>
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 085187b..3e2f1d3 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -18,6 +18,7 @@
>  #define LINUX_PCI_H
>
>  #include <linux/pci_regs.h>	/* The pci register defines */
> +#include <asm/io.h>
>
>  /*
>   * The PCI interface treats multi-function devices as independent

The fix I applied to my tree uses linux/io.h instead, which is probably more 
correct (thanks David!).

-- 
Jesse Barnes, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/