linux-kernel - Re: [i2c] [PATCH v2] Add support for Dallas DS28CM00 Unique ID chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48FE22A2.7030604@mimc.co.uk>
Date:	Tue, 21 Oct 2008 19:42:42 +0100
From:	Mark Jackson <mpfj@...c.co.uk>
To:	Jean Delvare <khali@...ux-fr.org>
CC:	ben-linux@...ff.org, akpm@...ux-foundation.org, i2c@...sensors.org,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [i2c] [PATCH v2] Add support for Dallas DS28CM00 Unique ID chip

Jean Delvare wrote:
> On Tue, 21 Oct 2008 15:55:26 +0100, Mark Jackson wrote:
>> This patch adds support for the (I2C based) DS28CM00 ID chip.
>> (v2 after running through checkpatch)
>>
>> Signed-off-by: M.Jackson <mpfj@...c.co.uk> 
>> ---
>>  drivers/i2c/chips/Kconfig    |    7 ++
>>  drivers/i2c/chips/Makefile   |    1 +
>>  drivers/i2c/chips/ds28cm00.c |  166 ++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 174 insertions(+), 0 deletions(-)
> 
> Nack. No new drivers under drivers/i2c/chips please, it's going away
> soon.

Okay ... where should any new drivers be located ?

<...snip...>

>> +static int ds28cm00_attach_adapter(struct i2c_adapter *adapter);
>> +static int ds28cm00_detect(struct i2c_adapter *adapter, int address, int kind);
>> +static int ds28cm00_detach_client(struct i2c_client *client);
>> +
>> +/* This is the driver that will be inserted */
>> +static struct i2c_driver ds28cm00_driver = {
>> +	.driver = {
>> +		.name	= "ds28cm00",
>> +	},
>> +	.attach_adapter	= ds28cm00_attach_adapter,
>> +	.detach_client	= ds28cm00_detach_client,
>> +};
> 
> attach_adapter and detach_client are deprecated. Please use probe and
> remove instead.

Are there any existing chip drivers that use this new method ?

Thanks
Mark
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/