linux-kernel - Re: sched: add CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1224615681.661.3.camel@twins>
Date:	Tue, 21 Oct 2008 21:01:21 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	henrik@...tad.us
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org,
	Henrik Austad <henrik.austad@...il.com>
Subject: Re: sched: add CONFIG_SMP consistency

On Tue, 2008-10-21 at 20:45 +0200, henrik@...tad.us wrote:
> From: Henrik Austad <henrik.austad@...il.com>
> 
> Do not declare select_task_rq as part of sched_class when CONFIG_SMP is
> not set.

While a proper cleanup, could you do it by re-arranging the methods so
as to not create an additional ifdef?

Thanks

> Signed-off-by: Henrik Austad <henrik.austad@...il.com>
> ---
>  include/linux/sched.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index c226c7b..9e0e33c 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -898,8 +898,9 @@ struct sched_class {
>  	void (*enqueue_task) (struct rq *rq, struct task_struct *p, int wakeup);
>  	void (*dequeue_task) (struct rq *rq, struct task_struct *p, int sleep);
>  	void (*yield_task) (struct rq *rq);
> +#ifdef CONFIG_SMP
>  	int  (*select_task_rq)(struct task_struct *p, int sync);
> -
> +#endif
>  	void (*check_preempt_curr) (struct rq *rq, struct task_struct *p, int sync);
>  
>  	struct task_struct * (*pick_next_task) (struct rq *rq);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/