linux-kernel - [PATCH] block: convert ata_port_for_each_link to use a while loop to reduce code size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Oct 2008 21:24:32 +0100
From:	Richard Kennedy <richard@....demon.co.uk>
To:	jgarzik@...ox.com
Cc:	lkml <linux-kernel@...r.kernel.org>
Subject: [PATCH] block: convert ata_port_for_each_link to use a while loop
	to reduce code size

convert a for loop to a while loop in the ata_port_for_each_link macros
to reduce code size.

on x86_64 size reports reduction of text size in
	libata.ko : -272 bytes
	ahci.ko   : -44 bytes

Signed-off-by: Richard Kennedy <richard@....demon.co.uk>

----
This patch is against 2.6.27 git head.

I've been running this patch on my AMD64 desktop machine for several
days & have not seen any problems.
regards
Richard


diff --git a/include/linux/libata.h b/include/linux/libata.h
index 947cf84..bbe3b9d 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -1283,12 +1283,12 @@ extern struct ata_link *__ata_port_next_link(struct ata_port *ap,
 					     bool dev_only);
 
 #define __ata_port_for_each_link(link, ap) \
-	for ((link) = __ata_port_next_link((ap), NULL, false); (link); \
-	     (link) = __ata_port_next_link((ap), (link), false))
+	(link) = NULL; \
+	while (((link) = __ata_port_next_link((ap), (link), false)))
 
 #define ata_port_for_each_link(link, ap) \
-	for ((link) = __ata_port_next_link((ap), NULL, true); (link); \
-	     (link) = __ata_port_next_link((ap), (link), true))
+	(link) = NULL; \
+	while (((link) = __ata_port_next_link((ap), (link), true)))
 
 #define ata_link_for_each_dev(dev, link) \
 	for ((dev) = (link)->device; \


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/