linux-kernel - Re: [PATCH] edac/cell: enable polling mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 22 Oct 2008 07:58:54 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Jens Osterkamp <jens@...ux.vnet.ibm.com>
Cc:	Doug Thompson <dougthompson@...ssion.com>,
	bluesmoke-devel@...ts.sourceforge.net, cbe-oss-dev@...abs.org,
	arnd@...db.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] edac/cell: enable polling mode

On Tue, 2008-10-21 at 16:07 +0200, Jens Osterkamp wrote:
> From: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> 
> The edac driver on cell turned out to be not enabled because of a missing op_state.
> This patch introduces it. Verified to work on top of Bens next branch.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Jens Osterkamp <jens@...ux.vnet.ibm.com>

Acked-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> ---
> 
> Ben, can you please confirm this is the patch you wanted to send upstream ?

Yes.

> Index: linux-2.6/drivers/edac/cell_edac.c
> ===================================================================
> --- linux-2.6.orig/drivers/edac/cell_edac.c
> +++ linux-2.6/drivers/edac/cell_edac.c
> @@ -9,6 +9,7 @@
>   */
>  #undef DEBUG
>  
> +#include <linux/edac.h>
>  #include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/platform_device.h>
> @@ -164,6 +165,8 @@ static int __devinit cell_edac_probe(str
>  	if (regs == NULL)
>  		return -ENODEV;
>  
> +	edac_op_state = EDAC_OPSTATE_POLL;
> +
>  	/* Get channel population */
>  	reg = in_be64(&regs->mic_mnt_cfg);
>  	dev_dbg(&pdev->dev, "MIC_MNT_CFG = 0x%016lx\n", reg);
> ---
> 
> Gruß,
> 
> Jens
> 
> IBM Deutschland Entwicklung GmbH
> Vorsitzender des Aufsichtsrats: Martin Jetter
> Geschäftsführung: Erich Baier 
> Sitz der Gesellschaft: Böblingen
> Registergericht: Amtsgericht Stuttgart, HRB 243294

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/