linux-kernel - Re: Regression in 2.6.27-git from commit 43ac2ca3840f64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081021213723.GL17268@tuxdriver.com>
Date:	Tue, 21 Oct 2008 17:37:24 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	Jouni Malinen <jouni.malinen@...eros.com>,
	wireless <linux-wireless@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Regression in 2.6.27-git from commit 43ac2ca3840f64

On Tue, Oct 21, 2008 at 09:01:14AM -0700, Larry Finger wrote:
> On my x86_64 system, the mainline 2.6.27-git kernel (v2.6.27-6030-g6da0b38)
> shows the following anomaly with the 'iwlist scan' command:
> 
>           Cell 03 - Address: 00:14:BF:85:49:FA
>                     ESSID:"lwfdjf"
>                     Mode:Master
>                     Channel:1
>                     Frequency:2.412 GHz (Channel 1)
>                     Quality=66/100  Signal level:-62 dBm  Noise level=-68 dBm
>                     Encryption key:on
>                     IE: Unknown: 00066C7766646A66
>                     IE: Unknown: 010882848B962430486C
>                     IE: Unknown: 030101
>                     IE: Unknown: 2A0104
>                     IE: Unknown: 2F0104
>                     IE: Unknown: 32040C121860
>                     IE: Unknown: DD09001018020014000000
>                     IE: WPA Version 1
>                         Group Cipher : TKIP
>                         Pairwise Ciphers (1) : TKIP
>                         Authentication Suites (1) : PSK
>                     Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s; 18 Mb/s
>                               24 Mb/s; 36 Mb/s; 54 Mb/s; 6 Mb/s; 9 Mb/s
>                               12 Mb/s; 48 Mb/s
>                     Extra:tsf=0000014488aeb18b
>                     Extra: Last beacon: 448ms ago
> 
> This problem was bisected to commit 43ac2ca3840f64f699a239535c590fa7ebaaac27,
> entitled "mac80211: Handle scan result IEs in one block". The same bug is
> present in the wireless-testing tree.

I'm guessing that iwlist doesn't like the packed IEs?  Does this patch help?

John

P.S.  I'm not sure if this qualifies as actual userland breakage or not...

---

From: John W. Linville <linville@...driver.com>
Subject: [PATCH] mac80211: do not aggregate IEs from scan results

Signed-off-by: John W. Linville <linville@...driver.com>
---
 net/mac80211/scan.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/net/mac80211/scan.c b/net/mac80211/scan.c
index 416bb41..51ed74d 100644
--- a/net/mac80211/scan.c
+++ b/net/mac80211/scan.c
@@ -728,8 +728,6 @@ static void ieee80211_scan_add_ies(struct iw_request_info *info,
 
 	while (end - pos > IW_GENERIC_IE_MAX) {
 		next = pos + 2 + pos[1];
-		while (next + 2 + next[1] - pos < IW_GENERIC_IE_MAX)
-			next = next + 2 + next[1];
 
 		memset(&iwe, 0, sizeof(iwe));
 		iwe.cmd = IWEVGENIE;
-- 
1.5.4.3

-- 
John W. Linville		Linux should be at the core
linville@...driver.com			of your literate lifestyle.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/