linux-kernel - Re: [PATCH 5/7] kgdboc, tty: use tty open to start low level drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Oct 2008 16:49:09 -0500
From:	Jason Wessel <jason.wessel@...driver.com>
To:	kgdb-bugreport@...ts.sourceforge.net
CC:	linux-kernel@...r.kernel.org, alan@...rguk.ukuu.org.uk
Subject: Re: [PATCH 5/7] kgdboc, tty: use tty open to start low level drivers

Jason Wessel wrote:
> A few minor changes were needed in tty_io.c to deal with the fact that
> the inode and fpath.dentry were NULL with the generic flip structure.
>   

After further testing and review one patch hunk has been eliminated.

> Signed-off-by: Jason Wessel <jason.wessel@...driver.com>
> ---
>  drivers/char/tty_io.c      |   96 +++++++++++++++++++++++++++++++++++++++++---
>  drivers/serial/kgdboc.c    |   26 ++++++++----
>  include/linux/tty_driver.h |    5 ++
>  3 files changed, 113 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
> index fa44e6b..fe500ec 100644
> --- a/drivers/char/tty_io.c
> +++ b/drivers/char/tty_io.c
> @@ -1723,7 +1806,7 @@ void tty_release_dev(struct file *filp)
>  	release_tty(tty, idx);
>  
>  	/* Make this pty number available for reallocation */
> -	if (devpts)
> +	if (devpts && inode)
>  		devpts_kill_index(inode, idx);
>  }
>   

Specifically the call to devpts_kill_index() should get executed
and the above patch hunk has been removed.

Thanks,
Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/