linux-kernel - Re: */ in string confuses checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081022083141.GB22344@brain>
Date:	Wed, 22 Oct 2008 09:31:41 +0100
From:	Andy Whitcroft <apw@...dowen.org>
To:	penguin-kernel@...ove.sakura.ne.jp
Cc:	rdunlap@...otime.net, jschopp@...tin.ibm.com,
	linux-kernel@...r.kernel.org
Subject: Re: */ in string confuses checkpatch.pl

On Wed, Oct 22, 2008 at 08:56:17AM +0100, Andy Whitcroft wrote:
> On Tue, Oct 21, 2008 at 09:57:26AM +0900, penguin-kernel@...ove.sakura.ne.jp wrote:
> > Hello.
> > 
> > The below code confuses checkpatch.pl ver 0.21.
> > 
> > Regards.
> > ----------
> > # cat /tmp/foo.c
> > void foo(void)
> > {
> > 	bar(\" /proc/\\\\*/\");
> > 	bar(\" /proc/\\\\$/\");
> > }
> > # /usr/src/vanilla/linux-2.6.27.2/scripts/checkpatch.pl --file /tmp/foo.c
> > ERROR: need consistent spacing around \'/\' (ctx:WxV)
> > #4: FILE: tmp/foo.c:4:
> > +       bar(\" /proc/\\\\$/\");
> >               ^
> > 
> > total: 1 errors, 0 warnings, 5 lines checked
> > 
> > /tmp/foo.c has style problems, please review.  If any of these errors
> > are false positives report them to the maintainer, see
> > CHECKPATCH in MAINTAINERS.

Ok, I can see whats happened here.  Most of these \'s are extraneous.
Without those I can reproduce this.  Its a bug in the 'comment is open
at the start of hunk' detection.  I think I have updated this heuristic
to cope wit this.  Could you try your original patch (I assume there was
one) with the version below:

  http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing

Thanks for your report.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/