linux-kernel - Re: [PATCH] fix n_tty/pty input/output buffer full and other misc char handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081022103259.2d04729a@lxorguk.ukuu.org.uk>
Date:	Wed, 22 Oct 2008 10:32:59 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Joe Peterson <joe@...rush.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] fix n_tty/pty input/output buffer full and other misc
 char handling

> that ^C, ^Q, etc. can have effect) in non-canonical mode?  This would
> allow prevention of the gridlocks that still can be invoked when using
> stty -icanon in, say, an xterm.  For now, I took the conservative route
> in this patch, but let me know if a more permissive approach is better.

I suspect having thought about this a bit more that the proper logic is
in fact

	if (special case a)
	if (special case b)
	if (....)

	/* An ordinary character for the queue */
	if (queue_full) { ....}

and we should process everything that may have a special effect (flow
control, delete line, etc) before worrying about having room to store the
character whatever the tty ldisc state
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/