linux-kernel - Re: [RFC] CRIS: Move header files from include to arch/cris

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0810212011o2dfc2290ra6b227fec3d89a57@mail.gmail.com>
Date:	Tue, 21 Oct 2008 23:11:33 -0400
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Bryan Wu" <bryan.wu@...log.com>
Cc:	"Jesper Nilsson" <jesper.nilsson@...s.com>,
	"Sam Ravnborg" <sam@...nborg.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Mikael Starvik" <mikael.starvik@...s.com>
Subject: Re: [RFC] CRIS: Move header files from include to arch/cris

On Tue, Oct 21, 2008 at 22:36, Bryan Wu wrote:
> Mike Frysinger wrote:
>> On Tue, Oct 21, 2008 at 12:42, Jesper Nilsson wrote:
>>> That means that the machine dependent header files are moved to
>>> arch/cris/mach-{fs,a3}/include, while the common and architecture
>>> dependent files are moved to arch/cris/include.
>>>
>>> It is mainly this I'd like some input on, since most other ports
>>> that have moved their header files have put all headers in
>>> arch/*/include.
>>
>> that seems like a fairly obvious good idea to me ... i'm thinking we
>> should do it for Blackfin as well ...
>
> For moving machine header files to arch/blackfin/include/asm/mach-bf{527,
> 533, 537, 538, 548, 561},  we need to set a link such as
>  arch/blackfin/include/asm/mach -> arch/blackfin/include/asm/mach-bf527,
> because tons of drivers use the header file <asm/mach/xxxx.h>.

i dont think a ton of drivers use asm/mach/xxx.h considering how few
files we have in there.  a transition would be pretty trivial.

> But we don't like to setup a link that is the one reason we move our header
> file from include/asm-blackfin to our arch/blackfin/include/asm.

$arch/include/asm/ and $arch/asm/ would work the same.  just tweak the
actual -I path.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/