linux-kernel - Re: [PATCH -tip] x86: do_boot_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081022141354.GA26372@elte.hu>
Date:	Wed, 22 Oct 2008 16:13:54 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	Glauber Costa <glommer@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>
Subject: Re: [PATCH -tip] x86: do_boot_cpu - check if we have ESR register


* Cyrill Gorcunov <gorcunov@...il.com> wrote:

> We should touch ESR register if only we have it.
> The patch fixes the problem mentoined here
> 
> 	http://lkml.org/lkml/2008/10/17/147
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com>
> CC: Glauber Costa <glommer@...il.com>

> -		apic_write(APIC_ESR, 0);
> -		apic_read(APIC_ESR);
> +		if (APIC_INTEGRATED(apic_version[phys_apicid])) {
> +			apic_write(APIC_ESR, 0);
> +			apic_read(APIC_ESR);
> +		}

i'm wondering - is the server there really that old, that it has no 
integrated lapic? I.e. it's an i486 SMP box or so? Or perhaps some 
other, weird SMP box?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/