linux-kernel - Re: [PATCH -tip] x86: do_boot_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081022150635.GF9639@localhost>
Date:	Wed, 22 Oct 2008 19:06:35 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Glauber Costa <glommer@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Max Kellermann <mk@...all.com>
Subject: Re: [PATCH -tip] x86: do_boot_cpu - check if we have ESR register

[Ingo Molnar - Wed, Oct 22, 2008 at 05:04:16PM +0200]
| 
| * Cyrill Gorcunov <gorcunov@...il.com> wrote:
| 
| > [Ingo Molnar - Wed, Oct 22, 2008 at 04:59:09PM +0200]
| > | 
| > | > > | > -		apic_write(APIC_ESR, 0);
| > | > > | > -		apic_read(APIC_ESR);
| > | > > | > +		if (APIC_INTEGRATED(apic_version[phys_apicid])) {
| > | > > | > +			apic_write(APIC_ESR, 0);
| > | > > | > +			apic_read(APIC_ESR);
| > | > > | > +		}
| > | 
| > | this wouldnt build with certain configs:
| > | 
| > | arch/x86/kernel/smpboot.c: In function 'do_boot_cpu':
| > | arch/x86/kernel/smpboot.c:897: error: 'phys_apicid' undeclared (first use in this function)
| > | arch/x86/kernel/smpboot.c:897: error: (Each undeclared identifier is reported only once
| > | arch/x86/kernel/smpboot.c:897: error: for each function it appears in.)
| > | include/asm/io_32.h: In function 'memcpy_fromio':
| > | 
| > | because phys_apicid is not available in the !WAKE_SECONDARY_VIA_INIT 
| > | case. Changed it to boot_cpu_physical_apicid - that should be good 
| > | enough.
| > | 
| > | 	Ingo
| > | 
| > 
| > Did you fixed it? (oh... actually I've been compilling the patch
| > but had this CONFIG turned on and didn't catch this issue)
| 
| yeah, fixed it up, dont worry about it.
| 
| 	Ingo
| 

Thanks Ingo!

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/