linux-kernel - Re: [PATCH 4/4] Implement semaphore latency tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1224696137.20069.6.camel@twins>
Date:	Wed, 22 Oct 2008 19:22:17 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Török Edwin <edwintorok@...il.com>,
	sandmann@...mi.au.dk, linux-kernel@...r.kernel.org,
	Steven Rostedt <rostedt@...dmis.org>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [PATCH 4/4] Implement semaphore latency tracer

On Wed, 2008-10-22 at 17:48 +0200, Ingo Molnar wrote:
> * Török Edwin <edwintorok@...il.com> wrote:
> 
> > On 2008-10-22 18:28, Ingo Molnar wrote:
> > > hm, but the most common synchronization primitive are mutexes - and 
> > > those are not covered by your patchset.
> > >   
> > 
> > Indeed. I've seen a patch from Jason Baron to introduce tracepoints 
> > for mutexes, but the conclusion was that the tracepoints should be in 
> > lockstat instead.
> > 
> > And if lockstat is enabled Peter Zijlstra's 'contend with points' 
> > patch seems to do exactly what I want to.
> > 
> > However I think it would be useful to have (a tracepoints based?) 
> > latency tracker, which can be enabled/disabled at runtime, and which 
> > doesn't add any data to the mutex/semaphore structures. My patchset 
> > was a first attempt towards that, but it seems that such use of 
> > tracepoints is not welcome at this time?
> > 
> > Please tell me if I should continue working on this, or if I my 
> > patches are designed totally on the wrong way.
> 
> i think if you hook into Peter's lockstat APIs that should give us a 
> pretty good tracer, with no ugliness introduced. That would be rather 
> interesting. Peter, do you concur?

Yes, I've already suggested this. Use the exact same hooks that
lockdep/lockstat use.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/