linux-kernel - Re: [PATCH 04/11] ftrace: comment arch ftrace code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081022122654.744d9e85.akpm@linux-foundation.org>
Date:	Wed, 22 Oct 2008 12:26:54 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, fweisbec@...il.com,
	sagar.abhishek@...il.com, davem@...emloft.net, tglx@...utronix.de,
	peterz@...radead.org, torvalds@...ux-foundation.org,
	srostedt@...hat.com
Subject: Re: [PATCH 04/11] ftrace: comment arch ftrace code

On Wed, 22 Oct 2008 15:16:33 -0400 (EDT)
Steven Rostedt <rostedt@...dmis.org> wrote:

> > Also, I hope that the above code is called from within a
> > pagefault_disable()d region?  Or are relying upon some magical
> > side-effect of something which happens to do the same thing as
> > pagefault_disable()?  IOW: by what means does the above code ensure
> > that do_page_fault() will see in_atomic()==true?
> 
> This code is called from kstop_machine, or simply has interrupts disabled.

in_atomic() doesn't test irqs_disabled()!

Still, probe_kernel_write() correctly handles the
secret-argument-passing to do_page_fault().

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/