linux-kernel - Re: [PATCH] sound: correct bracketing in spdif test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h1vy9182m.wl%tiwai@suse.de>
Date:	Wed, 22 Oct 2008 08:02:09 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Matthew Ranostay <mranostay@...eddedalley.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sound: correct bracketing in spdif test

At Tue, 21 Oct 2008 23:38:31 -0400,
Matthew Ranostay wrote:
> 
> Harvey Harrison wrote:
> > Noticed by sparse:
> > sound/pci/hda/patch_sigmatel.c:1285:43: warning: dubious: !x & y
> > 
> > Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> > ---
> >  sound/pci/hda/patch_sigmatel.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> > index a2ac720..788fdc6 100644
> > --- a/sound/pci/hda/patch_sigmatel.c
> > +++ b/sound/pci/hda/patch_sigmatel.c
> > @@ -1282,7 +1282,7 @@ static int stac92xx_build_controls(struct hda_codec *codec)
> >  			return err;
> >  		spec->multiout.share_spdif = 1;
> >  	}
> > -	if (spec->dig_in_nid && (!spec->gpio_dir & 0x01)) {
> > +	if (spec->dig_in_nid && !(spec->gpio_dir & 0x01)) {
> >  		err = snd_hda_create_spdif_in_ctls(codec, spec->dig_in_nid);
> >  		if (err < 0)
> >  			return err;
> 
> Thanks for finding this.
> 
> 
> Acked-by: Matthew Ranostay <mranostay@...eddedalley.com>

Applied now.  Thanks!

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/