lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Tue, 21 Oct 2008 19:34:03 -0600
From:	dougthompson@...ssion.com
To:	jens@...ux.vnet.ibm.com, dougthompson@...ssion.com,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: [PATCH 1/1] edac: fix enabling of polling cell module

From: Benjamin Herrenschmidt <benh@...nel.crashing.org>

The edac driver on cell turned out to be not enabled because of a missing op_state.
This patch introduces it. Verified to work on top of Bens next branch.

Signed-off-by: Arnd Bergmann <arnd@...db.de>
Signed-off-by: Jens Osterkamp <jens@...ux.vnet.ibm.com>
Acked-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Signed-off-by: Doug Thompson <dougthompson@...ssion.com>

---

Ben, can you please confirm this is the patch you wanted to send upstream ?

Index: linux-2.6/drivers/edac/cell_edac.c
===================================================================
--- linux-2.6.orig/drivers/edac/cell_edac.c
+++ linux-2.6/drivers/edac/cell_edac.c
@@ -9,6 +9,7 @@
  */
 #undef DEBUG
 
+#include <linux/edac.h>
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/platform_device.h>
@@ -164,6 +165,8 @@ static int __devinit cell_edac_probe(str
 	if (regs == NULL)
 		return -ENODEV;
 
+	edac_op_state = EDAC_OPSTATE_POLL;
+
 	/* Get channel population */
 	reg = in_be64(&regs->mic_mnt_cfg);
 	dev_dbg(&pdev->dev, "MIC_MNT_CFG = 0x%016lx\n", reg);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ