linux-kernel - Re: [PATCH -mm] ftrace : Fix section mismatch warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081022070312.GA24749@elte.hu>
Date:	Wed, 22 Oct 2008 09:03:12 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Rakib Mullick <rakib.mullick@...il.com>
Cc:	linux-kernel@...r.kernel.org, rostedt@...dmis.com,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -mm] ftrace : Fix section mismatch warning.


* Ingo Molnar <mingo@...e.hu> wrote:

> 
> * Rakib Mullick <rakib.mullick@...il.com> wrote:
> 
> > WARNING: arch/x86/kernel/built-in.o(.text+0x11b41): Section mismatch
> > in reference from the variable ftrace_test_p6nop to the function
> > .init.text:ftrace_dyn_arch_init()
> > The function ftrace_test_p6nop() references
> > the function __init ftrace_dyn_arch_init().
> > This is often because ftrace_test_p6nop lacks a __init
> > annotation or the annotation of ftrace_dyn_arch_init is wrong.
> > 
> > WARNING: arch/x86/kernel/built-in.o(.text+0x11b4b): Section mismatch
> > in reference from the variable ftrace_test_nop5 to the function
> > .init.text:ftrace_dyn_arch_init()
> > The function ftrace_test_nop5() references
> > the function __init ftrace_dyn_arch_init().
> > This is often because ftrace_test_nop5 lacks a __init
> > annotation or the annotation of ftrace_dyn_arch_init is wrong.
> > 
> > This patch fixes the above warnings. Introduced by
> > 'linux-next.patch'(2.6.27-rc5-mm1-broken-out).
> > Thanks.
> > 
> > Signed-off-by: Md.Rakib H. Mullick(rakib.mullick@...il.com)
> 
> applied to tip/tracing/urgent, thanks!

actually, this patch is wrong: the problem highlighted in that warning 
is that ftrace_test_p6nop is non-__init while ftrace_dyn_arch_init() is 
__init. So the proper solution is to mark ftrace_test_p6nop init as 
well. (it's an assembly label so thus slightly more complex than usual, 
but doable.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/