linux-kernel - Re: [PATCH] fix WARN() for PPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1224743193.5865.11.camel@johannes.berg>
Date:	Thu, 23 Oct 2008 08:26:33 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Arjan van de Ven <arjan@...radead.org>,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	davem@...emloft.net,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: [PATCH] fix WARN() for PPC

On Wed, 2008-10-22 at 13:23 -0700, Jeremy Fitzhardinge wrote:
> Arjan van de Ven wrote:
> > From: Arjan van de Ven <arjan@...ux.intel.com>
> > Date: Mon, 20 Oct 2008 14:41:03 -0700
> > Subject: [PATCH] fix WARN() for PPC
> >
> > powerpc doesn't use the generic WARN_ON infrastructure.
> 
> Hm, why's that now?  The generic infrastructure was taken from powerpc, 
> and I thought I'd converted it...

The definition of "generic" changed midway. When you did the "generic"
infrastructure, it was written to use traps for both WARN and BUG. But
then somebody didn't like that and added new "generic" infrastructure
(the one Arjan is talking about) which doesn't use traps for WARN but
rather an unlikely() and an actual function call etc. Then Arjan
improved the latter "generic" infrastructure without regard for the
original one.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)