linux-kernel - Re: [PATCH] Add block device speciffic splice write method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081023000315.6aa579f2.akpm@linux-foundation.org>
Date:	Thu, 23 Oct 2008 00:03:15 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	Dmitri Monakhov <dmonakhov@...nvz.org>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] Add block device speciffic splice write method

On Thu, 23 Oct 2008 08:51:13 +0200 Jens Axboe <jens.axboe@...cle.com> wrote:

> On Wed, Oct 22 2008, Andrew Morton wrote:
> > On Thu, 23 Oct 2008 08:29:23 +0200 Jens Axboe <jens.axboe@...cle.com> wrote:
> > 
> > > > But really it'd be better if the throttling happened down in
> > > > pipe_to_file(), on a per-page basis.  As it stands we can dirty an
> > > > arbitrary number of pagecache pages without throttling.  I think?
> > > 
> > > That's pretty exactly why it isn't done in the actor, to avoid doing it
> > > per-page. As it's going to be PIPE_BUFFERS (16) pages max, I think this
> > > is better.
> > > 
> > > Back in the splice early days, the balance_dirty_pages() actually showed
> > > up in profiles when it was done on a per-page basis. So I'm reluctant to
> > > change it :-)
> > 
> > That's why (the misnamed) balance_dirty_pages_ratelimited() exists?
> 
> I think that is what was used, but the details are a little hazy at this
> point. So I can't say for sure.

All that function does is to bump a per-cpu variable and
once-per-thousand or so it does the balance.  If it was causing
problems in the splice application we want to know, because write()
uses it!

>  In this case it's moot anyway, since we can kill it.

Nope, we can only remove it if the fd is O_SYNC||is_sync().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/