linux-kernel - Re: [PATCH 2/5] w35und: remove unused wb35_open() and wb35

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081023094632.GC1849@elf.ucw.cz>
Date:	Thu, 23 Oct 2008 11:46:32 +0200
From:	Pavel Machek <pavel@...e.cz>
To:	Pekka J Enberg <penberg@...helsinki.fi>
Cc:	Greg Kroah-Hartman <greg@...ah.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] w35und: remove unused wb35_open() and wb35_close()
	functions

On Wed 2008-10-22 19:06:13, Pekka J Enberg wrote:
> From: Pekka Enberg <penberg@...helsinki.fi>
> 
> The functions are not used anywhere so remove them.
> 
> Cc: Pavel Machek <pavel@...e.cz>
> Signed-off-by: Pekka Enberg <penberg@...helsinki.fi>

ACK.

> ---
>  drivers/staging/winbond/linux/wbusb.c   |   19 -------------------
>  drivers/staging/winbond/linux/wbusb_f.h |    2 --
>  2 files changed, 0 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/staging/winbond/linux/wbusb.c b/drivers/staging/winbond/linux/wbusb.c
> index 4b989c5..c3394bf 100644
> --- a/drivers/staging/winbond/linux/wbusb.c
> +++ b/drivers/staging/winbond/linux/wbusb.c
> @@ -308,25 +308,6 @@ WbUsb_destroy(phw_data_t pHwData)
>  {
>  }
>  
> -int wb35_open(struct net_device *netdev)
> -{
> -	struct wb35_adapter * adapter = (struct wb35_adapter *)netdev->priv;
> -	phw_data_t pHwData = &adapter->sHwData;
> -
> -        netif_start_queue(netdev);
> -
> -	//TODO : put here temporarily
> -	hal_set_accept_broadcast(pHwData, 1); // open accept broadcast
> -
> -	return 0;
> -}
> -
> -int wb35_close(struct net_device *netdev)
> -{
> -	netif_stop_queue(netdev);
> -	return 0;
> -}
> -
>  static void wb35_disconnect(struct usb_interface *intf)
>  {
>  	struct wb35_adapter * adapter = usb_get_intfdata(intf);
> diff --git a/drivers/staging/winbond/linux/wbusb_f.h b/drivers/staging/winbond/linux/wbusb_f.h
> index 0402f66..a1d5946 100644
> --- a/drivers/staging/winbond/linux/wbusb_f.h
> +++ b/drivers/staging/winbond/linux/wbusb_f.h
> @@ -11,8 +11,6 @@
>  //
>  //+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  
> -int wb35_open(struct net_device *netdev);
> -int wb35_close(struct net_device *netdev);
>  unsigned char WbUsb_initial(phw_data_t pHwData);
>  void WbUsb_destroy(phw_data_t pHwData);
>  unsigned char WbWLanInitialize(struct wb35_adapter *adapter);

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/