linux-kernel - Re: linux-next: kernel/trace/trace.c:658: error:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c62985530810230757r411b4e3dj4ecec649cf8cf0b3@mail.gmail.com>
Date:	Thu, 23 Oct 2008 16:57:35 +0200
From:	"Frédéric Weisbecker" <fweisbec@...il.com>
To:	"Geert Uytterhoeven" <geert@...ux-m68k.org>
Cc:	"Alexey Dobriyan" <adobriyan@...il.com>,
	"Stephen Rothwell" <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Ingo Molnar" <mingo@...e.hu>
Subject: Re: linux-next: kernel/trace/trace.c:658: error:

2008/10/23 Geert Uytterhoeven <geert@...ux-m68k.org>:
> If kernel/trace/trace.c calls irqs_disabled_flags(), it should include
> the include that defines irqs_disabled_flags(). You should not add it to
> some other random include.
>
> It's also happening on m68k:
> http://kisskb.ellerman.id.au/kisskb/buildresult/50641/

The fact is that other archs include this header into their
asm/system.h. It seems that's because
they need some non-traced irq_save/restore .
I wanted to stay in the same approach because future use of
raw_local_irq could be used elsewhere
and seem to work perfectly whithout adding special headers on most
arch. But there will be some
bug report for each future use of these functions for alpha.... (and
even m68k as it seems).

What do you think? Should I let this patch as is or send a new one
(and one other for m68k).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/