linux-kernel - Re: [PATCH] tracing: fix a build error on alpha and m68k

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081023163850.GB16591@elte.hu>
Date:	Thu, 23 Oct 2008 18:38:50 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] tracing: fix a build error on alpha and m68k


* Alexey Dobriyan <adobriyan@...il.com> wrote:

> On Thu, Oct 23, 2008 at 07:27:48PM +0200, Frederic Weisbecker wrote:
> > When tracing is enabled, some arch have included <linux/irqflags.h>
> > on their <asm/system.h> but others like alpha or m68k don't.
> > 
> > Build error on alpha:
> > 
> > kernel/trace/trace.c: In function 'tracing_generic_entry_update':
> > kernel/trace/trace.c:658: error: implicit declaration of function 'irqs_disabled_flags'
> > kernel/trace/trace.c: In function 'tracing_cpumask_write':
> > kernel/trace/trace.c:2145: error: implicit declaration of function 'raw_local_irq_disable'
> > kernel/trace/trace.c:2162: error: implicit declaration of function 'raw_local_irq_enable'
> > kernel/trace/trace.c: In function 'trace_die_handler':
> > kernel/trace/trace.c:3039: error: 'DIE_OOPS' undeclared (first use in this function)
> > 
> > Build error on m68k:
> > http://kisskb.ellerman.id.au/kisskb/buildresult/50641/
> > 
> > 
> > Include it on kernel/trace/trace.c
> > 
> > Reported-by: Alexey Dobriyan <adobriyan@...il.com>
> > Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
> > ---
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index 78d5661..deb9684 100644
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -34,6 +34,7 @@
> >  
> >  #include <linux/stacktrace.h>
> >  #include <linux/ring_buffer.h>
> > +#include <linux/irqflags.h>
> 
> Sure, except it doesn't fix anything.

hm, zapped the commit then.

the problem is most likely that none of these architectures is lockdep 
enabled, hence they have no irqtrace wrappers, hence not all of the 
tracers can be built on them?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/