lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Oct 2008 19:06:44 +0200 From: "Frédéric Weisbecker" <fweisbec@...il.com> To: "Ingo Molnar" <mingo@...e.hu> Cc: "Alexey Dobriyan" <adobriyan@...il.com>, "Geert Uytterhoeven" <geert@...ux-m68k.org>, "Stephen Rothwell" <sfr@...b.auug.org.au>, linux-next@...r.kernel.org, linux-kernel@...r.kernel.org, "Steven Rostedt" <rostedt@...dmis.org> Subject: Re: [PATCH] tracing: fix a build error on alpha and m68k 2008/10/23 Ingo Molnar <mingo@...e.hu>: > to answer the "is that a lockdep or just trace feature" question: > > trace-irqflags was first written by me for the (crude) ftrace-precursor > latency tracer code in -rt, years ago. Then i reused it (and changed it > alot) for upstream lockdep, two years ago. Then ftrace came in this year > and reused it. > > so it's rather symbiotic ;-) > > So ... the tracers that rely on irqflags-tracing should definitely be > limited to architectures that provide TRACE_IRQFLAGS. The core trace.c > itself should probably not be restricted ... (and it should definitely > build) > > Ingo > Ok, so perhaps it needs a kind of disambiguation between CONFIG_TRACE_IRQFLAGS and CONFIG_TRACE_IRQFLAGS_SUPPORT :) So, if those arch may not support irqflags, I should forget about including linux/irqflags.h But to let the core trace.c to be built for other types of tracing, the best thing I see is to put some ifdef CONFIG_TRACE_IRQFLAGS on the tracing_cpumask functions and structure, and actually on the creation of this file. No bad feelings about this solution? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists