linux-kernel - Re: [GIT PULL/RESEND] kernel message catalog patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0810231433380.3287@nehalem.linux-foundation.org>
Date:	Thu, 23 Oct 2008 14:37:24 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [GIT PULL/RESEND] kernel message catalog patches

On Thu, 23 Oct 2008, Heiko Carstens wrote:
> 
> The whole point of the patch set is to add documentation for kernel
> messages that are emitted via printk. The documentation is supposed to
> help a sys admin to help understand what went wrong.

I'm still not convinced.

> Please note that this was initially an s390 only patch set but we moved
> the infrastructure to generic code since it looks like others want a
> facility like this too. iirc Andrew requested the move.

I do agree that it makes no sense as a s390 feature, but quite frankly, 
I don't think it makes sense AT ALL. It introduces the notion of fixed 
messages and people now suddenly need to worry about the hashes of the 
contents etc. Exactly the kind of thing that I don't personally EVER want 
to see, and certainly not inside the kernel.

If somebody really wants this, I seriously believe it would be better done 
as a separate out-of-kernel package. Because I don't think it's worth 
maintaining those hashed translations in-kernel, and I'm nto going to ask 
people to even bother.

But if it's in-kernel, other people are then going to complain about them 
not being maintained. And quite frankly, I'm neither willing nor 
interested in hearing those complaints or making them more "valid".

So please keep the kernel message catalog external. Or try to convince me. 
But don't send me a "please pull" without any explanation or any relevant 
convincing argument.

		Linus

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/