linux-kernel - Re: [PATCH] ftrace: ftrace dump on oops control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0810231900500.9459@gandalf.stny.rr.com>
Date:	Thu, 23 Oct 2008 19:02:06 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] ftrace: ftrace dump on oops control


On Thu, 23 Oct 2008, Randy Dunlap wrote:

> On Thu, 23 Oct 2008 15:15:27 -0400 (EDT) Steven Rostedt wrote:
> 
> > +/**
> > + * ftrace_dump_on_oops - variable to dump ftrace buffer on oops
> > + *
> > + * If there is an oops (or kernel panic) and the ftrace_dump_on_oops
> > + * is set, then ftrace_dump is called. This will output the contents
> > + * of the ftrace buffers to the console.  This is very useful for
> > + * capturing traces that lead to crashes and outputing it to a
> > + * serial console.
> > + *
> > + * It is default off, but you can enable it with either specifying
> > + * "ftrace_dump_on_oops" in the kernel command line, or setting
> > + * /proc/sys/kernel/ftrace_dump_on_oops to true.
> > + */
> > +int ftrace_dump_on_oops;
> 
> Hi Steven,
> 
> Please lose the /** (just use /*).  The documentation is a good thing,
> but we don't do kernel-doc for simple variables.
> That might be a good thing to add one day....

OK, will do. Yeah, this variable is kind of special, and I wanted it to
be documented well. Oh well, I'll have to wait for kernel-doc to do
variables ;-)

I'll send a new patch that does the update.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/