linux-kernel - Re: [dm-devel] [PATCH 10/13] dm: add core functions for request-based dm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <807b3a220810240044v1b9f12e3xc3bd5a429b9d4c5@mail.gmail.com>
Date:	Fri, 24 Oct 2008 13:14:50 +0530
From:	"Nikanth K" <nikanth@...il.com>
To:	"device-mapper development" <dm-devel@...hat.com>
Cc:	jens.axboe@...cle.com, agk@...hat.com,
	James.Bottomley@...senpartnership.com, j-nomura@...jp.nec.com,
	k-ueda@...jp.nec.com, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org,
	"Nikanth Karthikesan" <knikanth@...e.de>
Subject: Re: [dm-devel] [PATCH 10/13] dm: add core functions for request-based dm

On Fri, Sep 12, 2008 at 8:16 PM, Kiyoshi Ueda <k-ueda@...jp.nec.com> wrote:
<snip>

> +static int dm_make_request(struct request_queue *q, struct bio *bio)
> +{
> +       struct mapped_device *md = (struct mapped_device *)q->queuedata;
> +
> +       if (unlikely(bio_barrier(bio))) {
> +               bio_endio(bio, -EOPNOTSUPP);
> +               return 0;
> +       }
> +
<snip>

Why not add barrier support in the beginning itself, so that targets
can be developed with barriers in mind? At least can we make the target
to return error, instead of the core?

Thanks
Nikanth Karthikesan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/