linux-kernel - Re: [GIT *] iommu fixes for 2.6.28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081024110125.GA18869@elte.hu>
Date:	Fri, 24 Oct 2008 13:01:25 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	torvalds@...ux-foundation.org, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, tony.luck@...el.com
Subject: Re: [GIT *] iommu fixes for 2.6.28


* David Woodhouse <dwmw2@...radead.org> wrote:

> This contains a few iommu-related fixes -- it restores DMA remapping 
> on newer Intel hardware, which was disabled by the interrupt remapping 
> patches, adds IA64 support for the Intel IOMMU, and some other small 
> fixes.
> 
>  MAINTAINERS                      |    7 +
>  arch/x86/kernel/amd_iommu_init.c |    2 +-
>  arch/x86/kernel/pci-dma.c        |   16 ---
>  drivers/pci/dmar.c               |  119 +++++++++++++-----
>  drivers/pci/intel-iommu.c        |  250 ++++++++++++++++++++------------------
>  drivers/pci/quirks.c             |   14 ++
>  include/asm-x86/iommu.h          |    4 +
>  include/linux/dma_remapping.h    |   27 ++--
>  include/linux/intel-iommu.h      |   66 ++++++++---
>  9 files changed, 305 insertions(+), 200 deletions(-)

hm, i just updated to v2.6.28-rc1, and these changes broke the x86 
32-bit build:

  arch/x86/kernel/built-in.o: In function `dma_supported':
  (.text+0x5797): undefined reference to `forbid_dac'
  arch/x86/kernel/built-in.o: In function `iommu_setup':
  pci-dma.c:(.init.text+0x326c): undefined reference to `forbid_dac'
  pci-dma.c:(.init.text+0x328b): undefined reference to `forbid_dac'
  pci-dma.c:(.init.text+0x32aa): undefined reference to `forbid_dac'

seems to be caused by:

  5b6985c: intel-iommu: IA64 support

config attached. (allnoconfig seems to trigger it too)

	Ingo

View attachment "config" of type "text/plain" (50277 bytes)