linux-kernel - Re: [PATCH] Handle space after for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081024142315.GA6481@brain>
Date:	Fri, 24 Oct 2008 15:23:15 +0100
From:	Andy Whitcroft <apw@...dowen.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Handle space after for_each_* macros gracefully in
	checkpatch

On Fri, Oct 24, 2008 at 01:50:10PM +0200, Andi Kleen wrote:
> Handle space after for_each_* macros gracefully in checkpatch.pl
> 
> Anyone else seeing the irony of checkpatch.pl recommending to 
> use for_each_cpu_mask, but then not actually parsing it
> correctly.
> 
> When you write 
> 
> 	for_each_cpu_mask (...) { 
> 
> it would complain about the space between mask and the open bracket
> because it thinks it's a normal function call.
> 
> Fix this in a generic way. In theory someone could construct
> a normal function that starts with for_each_* and it would
> not warn, but I think that would be uncommon. The alternative
> of listing all macros was tried first, but turned out to 
> be unwieldly.
> 
> I think I covered most of the common ones available, the
> only exceptions are a few oddballs with leading prefix 
> like pnp_for_each* or zorro_for_each.

I am happy with this conceptually.  However when this was suggested
before there was a concensus that that it was not obvious whether this
was meant to be written as a function or a control and nothing was done.

So if people are with you on this, I am happy.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/