linux-kernel - Re: [PATCH] Check fops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081024123315.5ca3bc83@pedra.chehab.org>
Date:	Fri, 24 Oct 2008 12:33:15 -0200
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Laurent Pinchart <laurent.pinchart@...net.be>,
	linux-kernel@...r.kernel.org, airlied@...ux.ie, perex@...ex.cz,
	alan-jenkins@...fmail.co.uk
Subject: Re: [PATCH] Check fops_get() return value

On Thu, 16 Oct 2008 15:28:00 +0200
Takashi Iwai <tiwai@...e.de> wrote:

> >  
> >  	old_fops = filp->f_op;
> >  	filp->f_op = fops_get(&dev->driver->fops);
> > +	if (filp->f_op == NULL) {
> 
> I think the more standard style is
> 
>  if (!file->fop) {

Yes. This seems a good cleanup to the patch.

> 
> Except for that minor issue, it looks good to me.
> In any case,
> 
> Acked-by: Takashi Iwai <tiwai@...e.de>

You have my ack also.

Acked-by: Mauro Carvalho Chehab <mchehab@...hat.com>

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/