linux-kernel - Re: [PATCH] [powerpc] GPIO: Adding new Xilinx driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <fa686aa40810241453o876ae14tce3df7723b0f621b@mail.gmail.com>
Date:	Fri, 24 Oct 2008 15:53:49 -0600
From:	"Grant Likely" <grant.likely@...retlab.ca>
To:	avorontsov@...mvista.com
Cc:	"John Linn" <john.linn@...inx.com>, jwboyer@...ux.vnet.ibm.com,
	linuxppc-dev@...abs.org, "Kiran Sutariya" <kirans@...inx.com>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [powerpc] GPIO: Adding new Xilinx driver

On Fri, Oct 24, 2008 at 3:41 PM, Anton Vorontsov
<avorontsov@...mvista.com> wrote:
> On Fri, Oct 24, 2008 at 12:59:00PM -0700, John Linn wrote:
>> This driver supports the Xilinx XPS GPIO IP core which has the typical
>> GPIO features.
>>
>> Signed-off-by: Kiran Sutariya <kirans@...inx.com>
>> Signed-off-by: John Linn <john.linn@...inx.com>
>
> Looks good. Just few comments below.
>
<snip>
>
> If nothing has changed, we should place the arch-specific GPIO
> drivers into the arch/. So, Kconfig entry should go into the
> arch/powerpc/platforms/Kconfig.
>
> and the driver itself into arch/powerpc/sysdev/.

This isn't just a powerpc driver.  It is also used by microblaze so
I'd like to keep it in the common directory (Microblaze is in the
process of being reviewed for merging).

Thanks for the comments.
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/