linux-kernel - Re: Bloatwatch 2.6.28-rc1: i8042 DMI lookup tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 25 Oct 2008 00:15:44 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Matt Mackall <mpm@...enic.com>
cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: Bloatwatch 2.6.28-rc1: i8042 DMI lookup tables

On Fri, 24 Oct 2008, Matt Mackall wrote:

> We've added 12k of new initdata to allnoconfig builds for i8042 DMI
> lookup tables:
> 
> http://www.selenic.com/bloatwatch/?cmd=compare;v1=2.6.27;v2=2.6.28-rc1;part=/built-in/drivers
> 
> It looks like each table entry is > 320 bytes as we reserve four 80-byte
> slots in each for DMI match strings. 

Umm, and what is the actual problem with that, really?

OK, we can remove it from .init, but then it will be rotting in memory 
forever, which is quite sub-optimal, when this kind of DMI information is 
needed only during initialization.

We can make ->ident strings shorter, they do not serve any real purpose, 
and are there just for readability. Is it worth that?

We can make a config option which will guard existence of these lists, 
such as CONFIG_INPUT_BLACKLISTS, let id default to y and depend on 
EMBEDDED.

Any other reasonable ideas?

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/