linux-kernel - Re: [PULL] module, param and stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0810251603310.3327@nehalem.linux-foundation.org>
Date:	Sat, 25 Oct 2008 16:08:19 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Rusty Russell <rusty@...tcorp.com.au>
cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Arjan van de Ven <arjan@...radead.org>,
	Hugh Dickins <hugh@...itas.com>, walt <w41ter@...il.com>
Subject: Re: [PULL] module, param and stop_machine patches

On Sat, 25 Oct 2008, Linus Torvalds wrote:
>
> -early_initcall(stop_machine_init);
> +core_initcall(stop_machine_init);

Btw, this obviously implies that all stop_machine() users had better be 
later in the boot sequence.

And no, I didn't check that exhaustively. There's the tracing 
infrastructure, and it's also core_initcall(), but it should be linked 
later. And module loading will happen later. mm/page_alloc.c has special 
code for bootup, and intel-rng.c should be a normal driver.

So it _should_ be ok. But I really didn't test. And my default kernel 
config doesn't even have CONFIG_STOP_MACHINE enabled, so I'm not the best 
person to test. 

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/