linux-kernel - Re: ext3: fix ext3_dx_readdir hash collision handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Oct 2008 16:44:47 -0400
From:	Theodore Tso <tytso@....edu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Markus Trippelsdorf <markus@...ppelsdorf.de>,
	linux-kernel@...r.kernel.org, eugene@...ix.com, msnitzer@...ix.com,
	akpm@...ux-foundation.org
Subject: Re: ext3: fix ext3_dx_readdir hash collision handling - Regression

On Fri, Oct 24, 2008 at 09:08:26AM -0700, Linus Torvalds wrote:
> 
> Hmm. Ted? I have not tried to revert that commit that Markus pinpointed 
> (6a897cf447a83c9c3fd1b85a1e525c02d6eada7d: "ext3: fix ext3_dx_readdir hash 
> collision handling"), but now that I look at that "git bug", I am getting 
> pretty damn sure that it's exactly the same issue, and it's not a git bug 
> at all.

Yep, I can replicate it now.  It appears to only show up if you are
running with an x86_64 kernel.  I normally run with an x86_32 kernel,
so I didn't notice the problem.  The commit in question avoids
returning duplicate entries when there is a hash collision;
unfortunately, it seems to return duplicate entries for any large
directory if you are running on x86_64 (and possibly/probably other
64-bit platforms).  

I'm working on it, and should hopefully have a fix for you soon.  If
this is too annoying, you can revert it and I'll resubmit a fixed
version once I get a fix.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/