[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1225027353.4466.144.camel@sauron>
Date: Sun, 26 Oct 2008 15:22:33 +0200
From: Artem Bityutskiy <dedekind@...radead.org>
To: Harvey Harrison <harvey.harrison@...il.com>
Cc: Adrian Hunter <ext-adrian.hunter@...ia.com>,
Andrew Morton <akpm@...ux-foundation.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ubifs: endian handling fixes and annotations
On Sat, 2008-10-25 at 11:52 -0700, Harvey Harrison wrote:
> > > fs/ubifs/sb.c:300:19: warning: incorrect type in assignment (different base types)
> > > fs/ubifs/sb.c:300:19: expected restricted __le64 [usertype] ctime_sec
> > > fs/ubifs/sb.c:300:19: got int [signed] [assigned] tmp
> > > fs/ubifs/sb.c:301:19: warning: incorrect type in assignment (different base types)
> > > fs/ubifs/sb.c:301:19: expected restricted __le64 [usertype] mtime_sec
> > > fs/ubifs/sb.c:301:19: got int [signed] [assigned] tmp
> >
> > ... snip ...
> >
> > thanks for the patch. It's shame we did not fix this ourselves. We did
> > run sparse before submitting UBIFS and did not see these warnings.
> > Probably sparse has been improved recently. Anyway, thank you, I'll look
> > closer at your patch and apply it to ubifs-2.6.git.
> >
>
> Run sparse with -D__CHECK_ENDIAN__ to see these warnings.
Any idea why this is not default?
--
Best regards,
Artem Bityutskiy (Битюцкий Артём)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists