linux-kernel - Re: [PATCH] hwmon: w83781d doesn't link when built-in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081026163624.622a0931@hyperion.delvare>
Date:	Sun, 26 Oct 2008 16:36:24 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Wolfgang Grandegger <wg@...ndegger.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hwmon: w83781d doesn't link when built-in

Hi Geert,

On Sun, 26 Oct 2008 15:20:26 +0100 (CET), Geert Uytterhoeven wrote:
> When w83781d is built-in, the final links fails with the following vague error
> message:
> 
> `.exit.text' referenced in section `.init.text' of drivers/built-in.o: defined
> in discarded section `.exit.text' of drivers/built-in.o
> 
> w83781d_isa_unregister() cannot be marked __exit, as it's also called from
> sensors_w83781d_init(), which is marked __init.

Good catch, thanks for reporting. For some reason the link doesn't fail
here.

> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
>  drivers/hwmon/w83781d.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/drivers/hwmon/w83781d.c
> +++ b/drivers/hwmon/w83781d.c
> @@ -1968,7 +1968,7 @@ exit:
>  	return res;
>  }
>  
> -static void __exit
> +static void
>  w83781d_isa_unregister(void)
>  {
>  	if (pdev) {
> @@ -2017,7 +2017,7 @@ w83781d_isa_register(void)
>  	return 0;
>  }
>  
> -static void __exit
> +static void
>  w83781d_isa_unregister(void)
>  {
>  }

Applied, thanks. I'll send this to Linus together with several other
hwmon patches later today.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/