linux-kernel - Re: Bug in workqueues [was: Usb devices randomly aren't detected with 2.6.28-rc1-git1]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0810261057290.5200@nehalem.linux-foundation.org>
Date:	Sun, 26 Oct 2008 11:01:11 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
cc:	Alan Stern <stern@...land.harvard.edu>,
	"Mikko C." <mikko.cal@...il.com>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Oleg Nesterov <oleg@...sign.ru>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: Bug in workqueues [was: Usb devices randomly aren't detected
 with 2.6.28-rc1-git1]



On Sun, 26 Oct 2008, Rafael J. Wysocki wrote:
> > 
> > So apparently flush_workqueue() isn't working.
> 
> Let's make that more visible (adding CCs). :-)

Isn't this the same thing that was fixed by commit 
4403b406d4369a275d483ece6ddee0088cc0d592: aka 'Revert "Call 
init_workqueues before pre smp initcalls."'

The bug was that init_workqueues was called too early, causing it to have 
wrong initialization of its CPU masks, which caused various random 
problems since it wouldn't run workqueues on anything but the boot CPU.

It is hidden by various config options (eg if you enable suspend, for 
example), which is why it probably took some time for people to notice.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/