linux-kernel - Re: staging: me4000: remove duplicated #include's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3aaafc130810261440q1f801a3bv8b74d5629aa1edfc@mail.gmail.com>
Date:	Sun, 26 Oct 2008 17:40:04 -0400
From:	"J.R. Mauro" <jrm8005@...il.com>
To:	"Adrian Bunk" <bunk@...nel.org>
Cc:	"Greg KH" <greg@...ah.com>, "Huang Weiyi" <weiyi.huang@...il.com>,
	gregkh@...e.de, linux-kernel@...r.kernel.org
Subject: Re: staging: me4000: remove duplicated #include's

On Sun, Oct 26, 2008 at 5:33 PM, Adrian Bunk <bunk@...nel.org> wrote:
> On Mon, Oct 20, 2008 at 02:18:22PM -0700, Greg KH wrote:
>> On Sat, Oct 18, 2008 at 11:52:15AM +0800, Huang Weiyi wrote:
>> > Removed duplicated #include's in drivers/staging/me4000/me4000.c
>> >    asm/uaccess.h
>> >    linux/fs.h
>> >
>> > Signed-off-by: Huang Weiyi <weiyi.huang@...il.com>
>> >
>> > diff --git a/drivers/staging/me4000/me4000.c b/drivers/staging/me4000/me4000.c
>> > index 862dd7f..90de6f0 100644
>> > --- a/drivers/staging/me4000/me4000.c
>> > +++ b/drivers/staging/me4000/me4000.c
>> > @@ -30,7 +30,6 @@
>> >  #include <asm/uaccess.h>
>> >  #include <linux/errno.h>
>> >  #include <linux/delay.h>
>> > -#include <linux/fs.h>
>> >  #include <linux/mm.h>
>> >  #include <linux/unistd.h>
>> >  #include <linux/list.h>
>> > @@ -39,7 +38,6 @@
>> >  #include <linux/poll.h>
>> >  #include <linux/vmalloc.h>
>> >  #include <asm/pgtable.h>
>> > -#include <asm/uaccess.h>
>> >  #include <linux/types.h>
>> >
>> >  #include <linux/slab.h>
>>
>> Hm, this doesn't apply anymore as some cleanups went in that should have
>> just made this not needed.
>>
>> But if you have a script I can run somewhere to verify it, I'd
>> appreciate it.
>
> linux-2.6$ make help | grep include
>  includecheck    - Check for duplicate included header files
> linux-2.6$

Is there a way to get this to just check in a user-specified
directory? I didn't see any options for that and adding
M=drivers/staging didn't help.

>
>> thanks,
>>
>> greg k-h
>
> cu
> Adrian
>
> --
>
>       "Is there not promise of rain?" Ling Tan asked suddenly out
>        of the darkness. There had been need of rain for many days.
>       "Only a promise," Lao Er said.
>                                       Pearl S. Buck - Dragon Seed
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/