[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081027105708.GB13895@elte.hu>
Date: Mon, 27 Oct 2008 11:57:08 +0100
From: Ingo Molnar <mingo@...e.hu>
To: Willy Tarreau <w@....eu>
Cc: Joe Damato <ice799@...il.com>, linux-x86_64@...r.kernel.org,
linux-newbie@...r.kernel.org, kernel-janitors@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/12] x86: Cleanup idt, gdt/ldt/tss structs
* Willy Tarreau <w@....eu> wrote:
> On Fri, Oct 24, 2008 at 08:15:20PM -0700, Joe Damato wrote:
> > Hi -
> >
> > This is my first submission to the kernel, so (beware!) please let me know if I can make any improvements on these patches.
>
> It looks like you provide one patch per file. You should group some
> of them together so that each patch does a functional change and
> everything still builds after incrementally applying that patch. The
> way you have splitted them will break builds if someone tries to
> build after patch 1 for instance.
yes, at every step the kernel is expected to build and boot fine.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists