linux-kernel - Re: staging: me4000: remove duplicated #include's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3aaafc130810270645m370a9f15ib1c5804348b6a7ed@mail.gmail.com>
Date:	Mon, 27 Oct 2008 09:45:32 -0400
From:	"J.R. Mauro" <jrm8005@...il.com>
To:	"Adrian Bunk" <bunk@...nel.org>
Cc:	"Greg KH" <greg@...ah.com>, "Huang Weiyi" <weiyi.huang@...il.com>,
	gregkh@...e.de, linux-kernel@...r.kernel.org
Subject: Re: staging: me4000: remove duplicated #include's

On Sun, Oct 26, 2008 at 6:05 PM, Adrian Bunk <bunk@...nel.org> wrote:
> On Sun, Oct 26, 2008 at 05:40:04PM -0400, J.R. Mauro wrote:
>> On Sun, Oct 26, 2008 at 5:33 PM, Adrian Bunk <bunk@...nel.org> wrote:
>> > On Mon, Oct 20, 2008 at 02:18:22PM -0700, Greg KH wrote:
>> >> On Sat, Oct 18, 2008 at 11:52:15AM +0800, Huang Weiyi wrote:
>> >> > Removed duplicated #include's in drivers/staging/me4000/me4000.c
>> >> >    asm/uaccess.h
>> >> >    linux/fs.h
>> >> >
>> >> > Signed-off-by: Huang Weiyi <weiyi.huang@...il.com>
>> >> >
>> >> > diff --git a/drivers/staging/me4000/me4000.c b/drivers/staging/me4000/me4000.c
>> >> > index 862dd7f..90de6f0 100644
>> >> > --- a/drivers/staging/me4000/me4000.c
>> >> > +++ b/drivers/staging/me4000/me4000.c
>> >> > @@ -30,7 +30,6 @@
>> >> >  #include <asm/uaccess.h>
>> >> >  #include <linux/errno.h>
>> >> >  #include <linux/delay.h>
>> >> > -#include <linux/fs.h>
>> >> >  #include <linux/mm.h>
>> >> >  #include <linux/unistd.h>
>> >> >  #include <linux/list.h>
>> >> > @@ -39,7 +38,6 @@
>> >> >  #include <linux/poll.h>
>> >> >  #include <linux/vmalloc.h>
>> >> >  #include <asm/pgtable.h>
>> >> > -#include <asm/uaccess.h>
>> >> >  #include <linux/types.h>
>> >> >
>> >> >  #include <linux/slab.h>
>> >>
>> >> Hm, this doesn't apply anymore as some cleanups went in that should have
>> >> just made this not needed.
>> >>
>> >> But if you have a script I can run somewhere to verify it, I'd
>> >> appreciate it.
>> >
>> > linux-2.6$ make help | grep include
>> >  includecheck    - Check for duplicate included header files
>> > linux-2.6$
>>
>> Is there a way to get this to just check in a user-specified
>> directory? I didn't see any options for that and adding
>> M=drivers/staging didn't help.
>
> Pipe the output through grep.
>
> Or if you really want to limit what gets checked, setting the path in
> the Makefile is trivial.

Yes, I guess I meant something like this quick-n-dirty patch. I got
bored waiting for the includecheck to finish on the whole source tree,
so it's nice to be able to tell it to check only what I'm interested
in.

(don't try to apply this patch as gmail mutilates tabs)
---

diff --git a/Makefile b/Makefile
index e9c5d47..9b7891c 100644
--- a/Makefile
+++ b/Makefile
@@ -1524,7 +1524,7 @@ tags: FORCE
 # ---------------------------------------------------------------------------

 includecheck:
-       find * $(RCS_FIND_IGNORE) \
+       find $(if $(M),$(M)/)* $(RCS_FIND_IGNORE) \
                -name '*.[hcS]' -type f -print | sort \
                | xargs $(PERL) -w $(srctree)/scripts/checkincludes.pl



>
> cu
> Adrian
>
> --
>
>       "Is there not promise of rain?" Ling Tan asked suddenly out
>        of the darkness. There had been need of rain for many days.
>       "Only a promise," Lao Er said.
>                                       Pearl S. Buck - Dragon Seed
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/